Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add numpy op full_like, c++ impl, fix zeros_like, ones_like type infe… #16804

Merged
merged 1 commit into from
Dec 9, 2019
Merged

add numpy op full_like, c++ impl, fix zeros_like, ones_like type infe… #16804

merged 1 commit into from
Dec 9, 2019

Conversation

Alicia1529
Copy link
Contributor

Description

  1. add c++ implementation of numpy op full_like and please ignore the previous pr implemented with custom op
  2. fix the inferType problem in zeros_like, ones_like in issue [Bug][Numpy] zeros_like, ones_like does not respect dtype flag #16646

@haojin2 haojin2 self-assigned this Nov 13, 2019
@haojin2 haojin2 added the Numpy label Nov 13, 2019
@Alicia1529 Alicia1529 force-pushed the op_full_like branch 5 times, most recently from a6cde2b to 6039853 Compare November 18, 2019 09:02
@Alicia1529 Alicia1529 mentioned this pull request Nov 21, 2019
Closed
@Alicia1529 Alicia1529 force-pushed the op_full_like branch 3 times, most recently from 2ff2409 to 4853734 Compare November 27, 2019 10:43
haojin2
haojin2 approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 7736bfd into apache:master Dec 9, 2019
Alicia1529 pushed a commit to Alicia1529/incubator-mxnet that referenced this pull request Dec 9, 2019
@xinyu-intel @Alicia1529
skip quantized conv flaky case (apache#16866)
ae8fe0b 
* Fix quantized concat when inputs are mixed int8 and uint8

Change-Id: I4da04bf4502425134a466823fb5f73da2d7a419b

* skip flaky test

* trigger ci

[Numpy] add op full_like, c++ impl, fix zeros_like, ones_like type inference (apache#16804)
haojin2 pushed a commit that referenced this pull request Dec 9, 2019
@Alicia1529 @haojin2
skip quantized conv flaky case (#16866) (#16774)
5f5b83f 
* Fix quantized concat when inputs are mixed int8 and uint8

Change-Id: I4da04bf4502425134a466823fb5f73da2d7a419b

* skip flaky test

* trigger ci

[Numpy] add op full_like, c++ impl, fix zeros_like, ones_like type inference (#16804)
@Alicia1529 Alicia1529 mentioned this pull request Dec 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hgt312 hgt312 hgt312 left review comments

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alicia1529 @haojin2 @hgt312